Project: Android application for birth registration & newborn health data tracking

Community Google Summer of Code
, ,
141

I did not run it as the code quality was not good.

Here is a list of issues:

  • Still not following Java Conventions for naming files. Yes, this matters a lot. The conventions you should be following are:
    • ThisIsAClassName
    • thisIsAVariableOrMethodName
    • THIS_IS_A_CONSTANT_NAME,
    • here.is.a.packagename".
    • When camelcasing an acronym, do DvdPlayer, not DVDPlayer.
    • Also, see Google’s Java Style Guide, which is based on the Java conventions. You should read this.
  • You didn’t actually implement an ORM correctly, or at all that I can see. Android has a library for this called Room, which I expected you to use.
  • What is hospitalid? I"m genuinely confused by that one.
  • I would expect you to understand how to organize your classes into packages – if you knew Java, you should know this. It’s a fundamental concept.
  • LibreHealth is one word, not two. It’s never hyphenated
  • This is supposed to also track health data such as vaccinations as well.
  • Validations should happen both client-side and in the database. Remember that it’s relatively easy to subvert your code and store invalid data in your database.
  • You don’t need to build this using Android Studio. You can build using ./gradlew installDebug(for macOS or Linux) or ./gradlew.bat installDebug(for Windows). There are command-line tools for managing virtual devices and Genymotion also exists. Genymotion uses VirtualBox.

I would honestly strongly discourage @iainbarclay and the other mentors from accepting you.

Here is why:

  • I gave you a strong hint about the conventions prior, yet you didn’t look them up, Also, why didn’t you pick up on the fact that MainActivity is named in the manner it is and yet all of your classes are different?
  • I expected a marked improvement in the code, that’s what we care about and I just don’t see it. We wanna see that you can organize code coherently into packages (without prompting).

I do not want to discourage you from sticking around and working on your skills but I’m not 100% sure that you would succeed this year.

Google Code-in is meant to teach students who are assumed to know nothing. Google Summer of Code requires you have the experience going in. I’m sorry.