@tony @nileshprasad137 @teryhill @aethelwulffe I am opening this thread for discussions on my project : Remove and replace the old PDF generation code with a custom library dependent on a single external PHP library
Hello @Abhinav can you make a checklist of the major items of the project here.
Hi @Abhinav. Community Bonding Period is the time to plan out your project comprehensively, so that you don’t have any problems during work period. As Trodridge said, list down all the deliverables here and a plan on how to approach them as and when you like it. Your proposal is already quite comprehensive, so you won’t face any problems doing that.
And also please be a bit patient with me for some time. I am also a student currently, and am having exams and stuff till 14-15th May. I’ll interact regularly after that. But, feel free to ping me anytime for help!
Same goes with you @naveen17797.
All the best to both of you.
Thanks @nileshprasad137 , i am experimenting with gitlab API which is crucial for my proposal
@nileshprasad137 currently I am finding all the places where PDFs are generated. Will drop a list including them soon.
And tell me how to proceed with project. I was thinking of making a branch named pdf_generator.
@Abhinav Yeah. Keep working on a new branch and keep the commits smaller in size and more in number.
I am having issues finding the demographics issue you mentioned. Also, can you look at #1132 PR for the addition of a layout accordion and see how it may integrate with you PR? I can’t get a review on that.
Sure @aethelwulffe . I also completed the code for Issues section should I wait or commit now only?
@aethelwulffe I think #1132 PR doesn’t relate to my project because it concerns about the menu style and not the PDFs.
Good. We can leave that PR in place. Now if someone would just review it…
-PLEASE continue with the issues section. Your branch is just fine at this point, and there is no problem with continuing on for a complete feature run. I can test as we go for bit-to-bit. This is a major defined project, so I have no problem testing a multitude of features at once.
@teryhill @aethelwulffe @tony @nileshprasad137 I submitted the new code and just rewrote the whole code for History. Now olny patient encounters are left for the section and error removal for demographics. I will send the patch soon. Please check the code.