Project: Create web components for FHIR Resources

ok @sunbiz, thanks for explaining this!

Also even inside this file on L 123 a css selector .cityField was used to get the value.

This was added as a class inside the component here : L 96, should this be also changed ? because most of the components follow this same pattern !

I’ve added the complete appointment workflow in the react app, MR :

( there was small bug in a component which is fixed in this unmerged MR, after it gets merged a submodule updated is required, hence the MR is draft for now. )

implementation video

[04/07/21]: week 4 blog post

[11/07/21]: week 5 blog post

2 Likes

Hi, @Shashwat I am working on providing UI/UX feedback on the web components screens and have cloned the latest code. When I run the code using npm start I see these messages after clicking on the element link

Default element without passing URL

Default element without passing URL but with JSON

Default element when URL is passed

I have added lerna to the code by using npm i lerna -g but am not able to work through the issue. Could you kindly help me with the same. I need to run the code and access the screens in order to provide design feedback.

I have attached a feedback example for your reference.

hi @MeeJ !

The packages are probably not installed. There must be some error message in the browser console.

These are the installation steps mentioned in the README file:

  1. git clone <repo.git>
  2. install yarn and lerna using: npm i -g yarn lerna
  3. install ploymer cli to serve the static demo webpage npm i -g polymer-cli
  4. install dependencies by running lerna bootstrap --use-workspaces
  5. to run a development server: polymer serve --open (will open the demos)

Thanks for this! but these components will not be created as their utility is very minimal (suggested by @sunbiz ) :sweat_smile:. I have attached a screenshot of each component created this summer in the related issue on gitlab : here.

The components are also available on the demo link : LibreHealth FHIR Web Components Catalog

Does LibreHealth use React.js - #7 by satyaarthchhabra shifting this conversation to related project thread.

@satyaarthchhabra the import here is incorrect, it should be @lh-toolkit/fhir-appointment/fhir-appointment.js there is an extra /, If you remove the extra backslash it should work properly.

However I did not encounter this error on my machine also the build job was successful on gitlab.

I’ll be adding this fix to my current MR.


on the first thaught i also asumed this was the error when i removed the / then also error remain the same

This can only happen if the workspace packages are not installed.

After bootstrapping the packages, the node modules must contain the @lh-toolkit directory with the different packages. The issue could only be caused by uninitialised git submodule which should not happen if cloning is done recursively.

no issue now thanks for your cordination in helping me set up my environment

Thank you, Shashwat I have got it running. As I am working on it, feel free to let me know if you need help with UI/UX work for a specific component.

@sunbiz I have edited this MR according to your comment. This component will be required for a couple of screens that I plan to implement this week , can you please review this before other open MR’s… Thanks!!

Looks good… merged! Please resolve any conflicts in other MRs

1 Like

@sunbiz can you please review this MR before others…

I’ve fixed the test job fail in the medication request MR.

@sunbiz there was a small typo error causing the build job to fail :

1 Like

@MeeJ All of the components planned for this term are now created and merged, it would be great if you could provide some feedback for these components :

2 Likes

@sunbiz @MeeJ Would it be better if all the text-fields be either filled (preferably) or outlined ?

like here below : won’t it look better if all the fields were filled rather than some being outlined and some filled ?

Hi @Shashwat Sure, I will go through them today and will get back to you with feedback.

1 Like

Hi, @Shashwat I do feel that in the input field space, instead of keeping the placeholder as “Text,” adding a status value in a lighter text color would be intuitive for the user to understand. For example, if you look at the code field in the attached screenshot, the user need not see the entire code, but an example with format would make it easier to fill forms. Also, if you could add asterisks to indicate mandatory fields, that would be a good practice.

Kindly let us know what you think @sunbiz

Thank you, Meenal J

1 Like

Thanks a lot for this feedback @MeeJ!


@sunbiz Almost all of the resources accept empty data values(all fields unfilled), without any validation error. So which fields should be put in the required category ?